perl - 模块以 "1;"结尾，perlcritic提示它没有

有一个简单的模块

package Rrr;
use 5.014;
use warnings;
use namespace::sweep;
use Moo;
use Method::Signatures::Simple;

BEGIN {
    our $VERSION = '0.0.1';
}

has 'root' => (
    is => 'rw',
    default => 'root'
);

method func {
    say 'This is the func method from ' . __PACKAGE__ . ' with value: ', $self->root;
}

1;

perlcritic -1说

Code is not tidy at line 1, column 1.  See page 33 of PBP.  (Severity: 1)
Module does not end with "1;" at line 17, column 1.  Must end with a recognizable true value.  (Severity: 4)
Return value of flagged function ignored - say at line 18, column 5.  See pages 208,278 of PBP.  (Severity: 1)

如何使perlcritic开心？

编辑-基于@toolic的评论

是的，整洁有助于解决第一个问题(但Code is not tidy at line 1, column 1.并没有多大帮助)，因为差异是:

13c13
<     is => 'rw',
---
>     is      => 'rw',
18c18,19
<     say 'This is the func method from ' . __PACKAGE__ . ' with value: ', $self->root;
---
>     say 'This is the func method from ' . __PACKAGE__ . ' with value: ',
>       $self->root;

但仍然得到:

Module does not end with "1;" at line 17, column 1.  Must end with a recognizable true value.  (Severity: 4)
Return value of flagged function ignored - say at line 18, column 5.  See pages 208,278 of PBP.  (Severity: 1)

我的信条:

$ perlcritic --version
1.125

最佳答案

看起来method中的Method::Signatures::Simple关键字似乎丢掉了perlcritic。请注意，PPI分析以下程序的方式有所不同:

$ tools/ppidump 'method foo { 1 } 1;'
                    PPI::Document
                      PPI::Statement
[    1,   1,   1 ]     PPI::Token::Word         'method'
[    1,   8,   8 ]     PPI::Token::Word         'foo'
                        PPI::Structure::Block   { ... }
                          PPI::Statement
[    1,  14,  14 ]         PPI::Token::Number   '1'
[    1,  18,  18 ]     PPI::Token::Number       '1'
[    1,  19,  19 ]     PPI::Token::Structure    ';'

$ tools/ppidump 'sub foo { 1 } 1;'
                    PPI::Document
                      PPI::Statement::Sub
[    1,   1,   1 ]     PPI::Token::Word         'sub'
[    1,   5,   5 ]     PPI::Token::Word         'foo'
                        PPI::Structure::Block   { ... }
                          PPI::Statement
[    1,  11,  11 ]         PPI::Token::Number   '1'
                      PPI::Statement
[    1,  15,  15 ]     PPI::Token::Number       '1'
[    1,  16,  16 ]     PPI::Token::Structure    ';'

当使用method时，整个程序被视为一个单独的语句。当使用sub时，1;被视为一个单独的语句。

为了使perlcritic变得安静，可以在方法的右括号后面添加分号:

method func {
    ...
};

1;

或者

method func {
    ...
}

;1;

但是，我认为amon在注释中提出了一个好的观点:

关于perl - 模块以 "1;"结尾，perlcritic提示它没有，我们在Stack Overflow上找到一个类似的问题：https://stackoverflow.com/questions/31457885/

Perlcritic

perl - 模块以 "1;"结尾，perlcritic提示它没有