c - Eratosthenes筛，素数C

Closed. This question is off-topic。它当前不接受答案。
                            
                        
                    
                
                            
                                
                
                        
                            
                        
                    
                        
                            想改善这个问题吗？ Update the question，所以它是on-topic，用于堆栈溢出。
                        
                        2年前关闭。
                                                                                            
                
        
我正在编写一个使用Eratosthenes筛子查找质数的方法，直到1000年为止……但这是行不通的……这是我的全部代码，但是查找质数的“计算”在内部函数“ markPrimes”（我有信心说其余的代码都可以，所以我很确定问题出在这个函数中...

#include <stdio.h>
#include <stdlib.h>

typedef struct primal
{
    int number; /* a number */
    char mark;  /* flag marking the number as active (1) or inactive (0) */
} primal;


void initialize(primal *s,int size)
{
    int i;
    for(i=0;i<1000;i++)
    {
        s[i].number=i+1;
        s[i].mark=1; //1=prime number
    }
}

void markPrimes(primal *s,int size)
{
    /* add this function - it should mark all of the numbers in the passed primal array that are not prime numbers as inactive */
    //Brute Sieve of Eratosthenes Approach (0=not prime number)

    s[0].mark=0; //s[0].number=1 as on the function "initialize" I start from 1 not from 0
    int i,j;
    for (unsigned i = 2; i*i <size; i++)
    {
        if (s[i].mark == 1)
            for (unsigned j = i<<1;j<size;j+=i)
                s[j].mark = 0;
    }
}

int main(void)
{
    int i,j,prime_numbers[200];
    primal source_numbers[1000]; /* an array of source values */

    for(i=0;i<200;i++) prime_numbers[i]=0; /* initialize the prime numbers array to 0 */

    initialize(source_numbers,1000); /* initialize the source numbers array to hold the numbers 1-1000 */

    markPrimes(source_numbers,1000); /* identify the prime numbers in the source numbers array */

    /* copy the primes from the source numbers to the prime numbers array */
    for(i=0,j=0;i<1000;i++)
    {
        if(source_numbers[i].mark==1) /* if the current source number is a prime */
        {
            prime_numbers[j]=source_numbers[i].number; /* copy the number */
            j++; /* increment the target index */
        }
    }

    /* print the prime numbers */
    for(i=0,j=0;prime_numbers[i]!=0;i++,j++)
    {
        printf("%3d ",prime_numbers[i]);
        if(j==9) /* periodically print a newline and then reset j */
        {
            printf("\n");
            j=-1;
        }
    }
    return 0;
}

最佳答案

众所周知，C允许编程人员刺破自己的脚（别担心，我们每个人都有这样的伤痕），这就是这里发生的情况。

在您的内部循环中，您从1而不是0开始，因此您需要将实际数字减去1作为索引并添加该数字而不是索引：

void markPrimes(primal *s,int size)
{
    //Brute Sieve of Eratosthenes Approach (0=not prime number)

    int i,j;
    // 1 (one) is not prime per definition
    s[0].mark = 0;
    for (i = 1; i*i <size; i++)
    {;
        if (s[i].mark == 1) {
            // you start at 1 instead of 0, so you need to take the actual number
            // minus one as the index and add that number instead of the index.
            for ( j = 2 * s[i].number  - 1;j < size; j += s[i].number){
                s[j].mark = 0;
            }
        }
    }
}

关于c - Eratosthenes筛，素数C ，我们在Stack Overflow上找到一个类似的问题：https://stackoverflow.com/questions/43217138/