我已经解决了问题,现在它可以正常运行,我的问题是,构造函数出了什么问题?正如有人指出的那样,这是有问题的,但我找不到它,我也想从我的牌组中提取和删除一张卡,关于如何做这样的事情的任何指示?

我的甲板课:

 import java.util.*;


public class Deck {

    private static Card[] cards;
    private static int counter;

    int i=52;
    int x=0;

    public Deck(Card[] card){
this.cards=card;
    }



    public int createDeck(){

        cards = new Card[52];
        for (int a=0; a<=3; a++)
        {
            for (int b=0; b<=12; b++)
            {
                cards[x] = new Card(a,b);
                x++;
                counter++;
            }
        }

    }


    public Card[] resetDeck(){
        createDeck();
        return cards;
    }

    public static void getRandomCard(){
        int chosen = (int) (52*Math.random())+1;
        System.out.println(cards[chosen]);
    }

    public static int getCounter(){
        return counter;
    }

    public static void print(){

         for(int x=0;x<52;x++){
            System.out.println(Deck.cards[x]);
        }
    }


}


我的DecktestDriver

public class DeckTestDriver {
    public static void main(String[] args){

        Deck test = new Deck(new Card[52]);
        test.createDeck();

        int input =test.getCounter();
        System.out.println("Number of cards in Deck = "+input);

        System.out.print("looking at one card in the deck-----");
        test.getRandomCard();
        System.out.println(".........................");

        System.out.println("Printing full list of cards in deck");
        System.out.println(".........................");

    test.print();
    System.out.println();
    System.out.println(".........................");
    System.out.println();

    System.out.println("Creating New Deck");
    System.out.println(".........................");
    System.out.println();

    Deck test1 = new Deck(new Card[52]);
    test1.createDeck();
    System.out.println();

    System.out.println("Printing new full list of cards in deck");
    System.out.println(".........................");

test1.print();
System.out.println(".........................");
System.out.println();

int input1 =test1.getCounter();
System.out.println("Number of cards in Deck = "+input1);

System.out.print("looking at one card in the deck-----");
test1.getRandomCard();
System.out.println(".........................");

    }
}


我的卡类:

public class Card {

    private int CardFaceValue;
    private int CardFaceSuit;
    private int cardFlippedNum;
    private int cardFlippedSuit;
    final static int MIN_VALUE_NUM=1;
    final static String MIN_VALUE_SUIT="Diamond";
    final static int MAX_VALUE_NUM=13;
    final static String MAX_VALUE_SUIT="Spade";



    public Card(int cardFlippedNum,int cardFlippedSuit){
        cardFlippedNumber();
        cardFlippedSuitType();

    }



    public int cardFlippedNumber(){
        int cFn = (int) (Math.random()*13)+1;
        cardFlippedNum = cFn;
        return CardFaceValue;

    }
    public int cardFlippedSuitType(){
        int cFs = (int)(Math.random()*4)+1;

        cardFlippedSuit = cFs;

        return CardFaceSuit;

    }



    public int getNum(){

        return cardFlippedNum;
    }

    public int getSuit(){
        return cardFlippedSuit;

    }

    public String toString() {
        return (getCardName() + " of " + getSuitName());
    }

    public String getCardName() {
        switch (cardFlippedNum) {           //Change return cases to numbers if you want a number shown e.g: 1 of Hearts
        case 1:
            return ("Ace");
        case 2:
            return ("TWO");
        case 3:
            return ("THREE");
        case 4:
            return ("FOURTH");
        case 5:
            return ("FIVE");
        case 6:
            return ("SIX");
        case 7:
            return ("SEVEN");
        case 8:
            return ("EIGHT");
        case 9:
            return ("NINE");
        case 10:
            return ("TEN");
        case 11:
            return ("Jack");
        case 12:
            return ("Queen");
        case 13:
            return ("King");
        default:
            return ("" + cardFlippedNum);
        }
    }

    public String getSuitName() {
        switch (cardFlippedSuit) {
        case 1:
            return ("Diamonds");
        case 2:
            return ("Clubs");
        case 3:
            return ("Hearts");
        case 4:
            return ("Spades");
        default:
            return ("Invalid");
        }
    }



}


我的输出:

     Number of cards in Deck = 52
looking at one card in the deck-----Jack of Clubs
.........................
Printing full list of cards in deck
.........................
TWO of Spades
SIX of Clubs
NINE of Hearts
TWO of Diamonds
FOURTH of Clubs
FOURTH of Spades
TEN of Clubs
Jack of Spades
EIGHT of Diamonds
Queen of Diamonds
Queen of Diamonds
TEN of Spades
EIGHT of Hearts
Ace of Hearts
SIX of Diamonds
King of Clubs
THREE of Diamonds
TWO of Hearts
SIX of Spades
SIX of Hearts
THREE of Spades
EIGHT of Hearts
FIVE of Clubs
EIGHT of Diamonds
Jack of Clubs
Ace of Diamonds
NINE of Diamonds
SEVEN of Hearts
TEN of Diamonds
SEVEN of Diamonds
SEVEN of Diamonds
EIGHT of Hearts
FIVE of Hearts
THREE of Clubs
THREE of Spades
FIVE of Spades
TWO of Diamonds
TWO of Clubs
NINE of Hearts
FIVE of Hearts
SIX of Spades
TEN of Diamonds
FOURTH of Hearts
King of Hearts
Ace of Spades
THREE of Spades
NINE of Spades
King of Spades
King of Diamonds
King of Diamonds
Jack of Hearts
THREE of Clubs

.........................

Creating New Deck
.........................


Printing new full list of cards in deck
.........................
Ace of Clubs
SEVEN of Hearts
Queen of Clubs
TWO of Diamonds
King of Spades
Ace of Hearts
Ace of Spades
FOURTH of Spades
NINE of Spades
TWO of Hearts
FOURTH of Hearts
THREE of Hearts
THREE of Spades
Ace of Spades
Ace of Diamonds
Jack of Spades
TWO of Diamonds
Queen of Clubs
SIX of Hearts
TEN of Clubs
EIGHT of Diamonds
TWO of Spades
King of Hearts
TWO of Hearts
King of Hearts
NINE of Spades
FOURTH of Hearts
FIVE of Hearts
SIX of Clubs
Jack of Hearts
FOURTH of Spades
Queen of Clubs
TWO of Clubs
Ace of Clubs
NINE of Spades
TEN of Clubs
SIX of Spades
Jack of Spades
Queen of Spades
TWO of Diamonds
EIGHT of Spades
SIX of Hearts
Ace of Diamonds
FOURTH of Diamonds
Queen of Diamonds
Jack of Hearts
TWO of Clubs
FOURTH of Diamonds
SIX of Diamonds
King of Diamonds
TWO of Spades
TEN of Diamonds
.........................

Number of cards in Deck = 104
looking at one card in the deck-----SIX of Clubs
.........................

最佳答案



Deck test = new Deck(new Card[52]);


您从未调用过createDeck()。顺便说一下,您的构造函数和createDeck有点精神分裂症。您将卡片组传递到构造函数中,但是如果不创建新数组就无法创建空白卡片组。

编辑


关于精神分裂症...

对于Deck的构造函数,您需要:

公共甲板(卡片[]卡){
      this.cards = card;
   }

奇怪的是,我将卡片组视为卡片组,但是您将卡片传递到卡片组中。这可能只是样式问题。但是,我很快就会期望:

公共Deck(){
     createDeck();
 }
顺便说一下,createDeck()有点怪异-它应该返回int但没有return语句。签名中的“无效”返回可能会更好。而且我会将其设为私有。如果有人想要一个新的Deck,他们应该使用Deck deck = new Deck();,而不是createDeck();
我绝不会让Deck将Cards []数组返回给用户。 Deck内的数据结构和其他内部事务与人无关。 resetDeck()这样做。不返回Card []意味着Deck必须提供诸如Card getTopCard()Card getRandomCard()之类的方法,因为它不再“打开和服”。但这是一件好事-我们希望Deck(一个非常不错的名词)具有允许人操纵套牌的动词式方法。
我看到一个非标准的循环构造:for (int b=0; b<=12; b++)这没错。但是,一般来讲,循环的条件部分不带for(int b=0; b<13; b++)话虽如此,当循环不是从零开始时,我会忽略这个半标准。
在Card中,我看到public String getCardName()。考虑一个稍微不同的实现。关键是通过定义数据结构而不是编写显式代码来消除代码行(从而消除错误)。查看由单行运行时代码代替的switch语句的运行方式。 cardNames的String数组是新的,但它是编译时代码,不太可能引入错误。



public class Card {
    ...
    private static final String[] cardName = new String[] {'ONE','TWO','THREE', ...etc};
    ...
    public String getCardName() {
        return cardName[cardFlippedNum];
        }

    }

关于java - 卡DeckDriver Java,我们在Stack Overflow上找到一个类似的问题:https://stackoverflow.com/questions/10544398/

10-09 09:34