java - 在SQLite Android中保存元素

我想在anndroid应用程序中将DatabaseTableDay保存到我的sqlite，但发生了一些错误。
我的DatabaseDAODay是：

public class DatabaseDAODay {

    public static final String TAG = "DaysDAO";

    // Database fields
    private SQLiteDatabase mDatabase;
    private DatabaseHelper mDbHelper;
    private Context mContext;
    private String[] mAllColumns = { DatabaseHelper.COLUMN_DAY_ID,
            DatabaseHelper.COLUMN_DAY_NAME, DatabaseHelper.COLUMN_DAY_WEIGHT};

    public DatabaseDAODay(Context context) {
        this.mContext = context;
        mDbHelper = new DatabaseHelper(context);
        // open the database
        try {
            open();
        } catch (SQLException e) {
            Log.e(TAG, "SQLException on openning database " + e.getMessage());
            e.printStackTrace();
        }
    }

    public void open() throws SQLException {
        mDatabase = mDbHelper.getWritableDatabase();
    }

    public void close() {
        mDbHelper.close();
    }

    public DatabaseTableDay createDay(String name, float weight, Long id) {
        ContentValues values = new ContentValues();
        values.put(DatabaseHelper.COLUMN_DAY_NAME, name);
        values.put(DatabaseHelper.COLUMN_DAY_WEIGHT, weight);
        long insertId = id;
        Cursor cursor = mDatabase.query(DatabaseHelper.TABLE_DAYS, mAllColumns,
                DatabaseHelper.COLUMN_DAY_ID + " = " + insertId, null, null,
                null, null);
        DatabaseTableDay newDay = new DatabaseTableDay();
        if(cursor != null && cursor.moveToFirst()){
            newDay = cursorToDay(cursor);
            cursor.close();
            Toast.makeText(mContext,"im here",Toast.LENGTH_LONG).show();
        }
        return newDay;
    }



    public void deleteDay(DatabaseTableDay databaseTableDay) {
        long id = databaseTableDay.getId();
        // delete all employees of this company
        DatabaseDAOActivity databaseDAOActivity = new DatabaseDAOActivity(mContext);
        List<DatabaseTableActivity> databaseTableActivities = databaseDAOActivity.getActivitiesOfDay(id);
        if (databaseTableActivities != null && !databaseTableActivities.isEmpty()) {
            for (DatabaseTableActivity e : databaseTableActivities) {
                databaseDAOActivity.deleteActivity(e);
            }
        }

        System.out.println("the deleted day has the id: " + id);
        mDatabase.delete(DatabaseHelper.TABLE_DAYS, DatabaseHelper.COLUMN_DAY_ID
                + " = " + id, null);
    }


    public List<DatabaseTableDay> getAllDays() {
        List<DatabaseTableDay> listDays = new ArrayList<DatabaseTableDay>();

        Cursor cursor = mDatabase.query(DatabaseHelper.TABLE_DAYS, mAllColumns,
                null, null, null, null, null);
        if (cursor != null) {
            cursor.moveToFirst();
            while (!cursor.isAfterLast()) {
                DatabaseTableDay day = cursorToDay(cursor);
                listDays.add(day);
                cursor.moveToNext();
            }
            // make sure to close the cursor
            cursor.close();
        }
        return listDays;
    }


    public DatabaseTableDay getDayById(long id) {
        Cursor cursor = mDatabase.query(DatabaseHelper.TABLE_DAYS, mAllColumns,
                DatabaseHelper.COLUMN_DAY_ID + " = ?",
                new String[] { String.valueOf(id) }, null, null, null);
        if (cursor != null) {
            cursor.moveToFirst();
        }

        DatabaseTableDay databaseTableDay = cursorToDay(cursor);
        return databaseTableDay;
    }

    protected DatabaseTableDay cursorToDay(Cursor cursor) {
        DatabaseTableDay databaseTableDay = new DatabaseTableDay();
        databaseTableDay.setId(cursor.getLong(0));
        databaseTableDay.setName(cursor.getString(1));
        databaseTableDay.setWeight(cursor.getLong(2));
        return databaseTableDay;
    }


}

我试图通过以下方式来拯救它：

saveButton.setOnClickListener(new View.OnClickListener() {
    @Override
    public void onClick(View v) {
        DatabaseTableDay databaseTableDay = databaseDAODay.createDay(
                editText.getText().toString(), 100f, new Long(myId));

        List<DatabaseTableDay> list = databaseDAODay.getAllDays();
    }
});

但是list还是空的。
可能的问题是createDay()中的DatabaseDAODay方法，因为if condition始终为空并且应用程序不运行cursorToDay()方法。
我有问题，没有条件，如果只有cursot.moveToFirst()然后cursorToDay()有NullPoinerException-因为coursor是空的。我跟踪this并设置条件!=null，但实际上什么都没有发生，列表总是空的…
我该如何解决我的问题？

最佳答案

关于createDay()的问题您是对的：您尝试使用insert()从数据库中读取数据，而不是使用query()插入新的一天。
改变方法如下：

public DatabaseTableDay createDay(String name, float weight, Long id) {

    DatabaseTableDay dayToReturn;
    ContentValues values = new ContentValues();
    values.put(DatabaseHelper.COLUMN_DAY_NAME, name);
    values.put(DatabaseHelper.COLUMN_DAY_WEIGHT, weight);
    values.put(DatabaseHelper.COLUMN_DAY_ID, id);

    long resID = mDatabase.insert(DatabaseHelper.TABLE_DAYS, null, values);
    if (resID == -1)
    {
       // something went wrong, do error handling here
       dayToReturn = null;
    }
    else
    {
        // no error: resID is "the row ID of the newly inserted row"
        // you only need this info if you are using autoincrement
        // not if you set the ID yourself

        // all right, this will work -
        // but somehow it hurts a little to retrieve an entry I just added.
        // I'd like much more to simply use a constructor with all the values
        // and create a new DatabaseTableDay instance
        dayToReturn = getDayById(id);
    }

    return dayToReturn;
}

另请参见SQLiteDatabase insert()