我试图写一个Sudoku难题求解器,到目前为止,我一直在努力让它显示难题。到目前为止,这是我的代码:
class Cell:
'''A cell for the soduku game.'''
def __init__(self):
#This is our constructor
self.__done = False #We are not finished at the start
self.__answer = (1,2,3,4,5,6,7,8,9) #Here is the tuple containing all of our possibilities
self.__setnum = 8 #This will be used later when we set the number.
def __str__(self):
'''This formats what the cell returns.'''
answer = 'This cell can be: '
answer += str(self.__answer) #This pulls our answer from our tuple
return answer
def get_possible(self):
'''This tells us what our possibilities exist.'''
answer = ()
return self.__answer
def is_done(self):
'''Does a simple check on a variable to determine if we are done.'''
return self.__done
def remove(self, number):
'''Removes a possibility from the possibility tuple.'''
if number == 1 or 2 or 3 or 4 or 5 or 6 or 7 or 8 or 9: #Checks if we have a valid answer
temp = list(self.__answer) #Here is the secret: We change the tuple to a list, which we can easily modify, and than turn it back.
temp.remove(number)
self.__answer = tuple(temp)
def set_number(self, number):
'''Removes all but one possibility from the possibility tuple. Also sets "__done" to true.'''
answer = 8
for num in self.__answer:
if num == number:
answer = number #Checks if the number is in the tuple, and than sets that value as the tuple, which becomes an integer.
self.__answer = answer
self.__done = True
return self.__answer
那是用于单元格的,下面是网格的代码:
class Grid:
'''The grid for the soduku game.'''
def __init__(self, puzzle):
'''Constructs the soduku puzzle from the file.'''
self.__file = open(puzzle)
self.__puzzle = ''
self.__template = ' | | \n | | \n | | \n | | \n | | \n | | \n | | \n | | \n | | \n'
for char in self.__file:
if char == '.':
self.__puzzle += ' '
else:
self.__puzzle += char
count = 0
self.__template_list = list(self.__template)
for char in self.__puzzle:
if char != '|':
if char == '.' or ' ':
self.__template_list[count] = ' '
else:
self.__template_list[count] = char
self.__answer = ''
for char in self.__template_list:
self.__answer += char
self.__file.close()
def __str__(self):
'''Prints the soduku puzzle nicely.'''
return self.__answer
尝试打印时,会出现两条垂直的管道(|)。有人可以告诉我我在做什么错吗?
最佳答案
您的代码确实很难阅读。您应该将问题分解为子问题,并在逻辑上进行结构化。
但是要直接回答您的问题,请在第7行中为self.__template
分配一个空模板。在第14行中,您正在将模板转换为字符列表(为什么?毕竟您不写它),并将其分配给self.__template_list
。最后,在第21至23行中,您遍历了模板字符列表(仍然为空),并将其附加到self.__answer
,然后在__str__()
中进行打印。因此,您只得到管道。
也许我可以给您一些有关如何改进代码的提示:
网格的文本表示形式应与网格的一般概念无关,因此不应涉及Grid类的大多数方法。在您的情况下,它会乱扔__init__()
方法,并且很难理解该方法的实际作用。您可以对网格执行几项操作,这些操作不需要知道网格的最终显示方式(如果有的话)。
输出网格的代码应完全限于对此负责的方法,在您的情况下为__str__()
。
对于与其他方法或类用户无关的变量,请使用局部变量而不是成员变量。不必要的成员变量会使您的代码难以理解,效率降低,并且在调试时(例如,使用dir()
检查实例成员时)会使您感到困惑。
考虑一个更逻辑地表示您的网格的数据结构(并且仅包含必要的数据,而不包含多余的表示细节)。我建议使用一个列表列表,因为在python中非常容易操作(例如,您也可以使用二维numpy数组)。
我建议类似以下内容:
class Grid:
'''The grid for the soduku game.'''
def __init__(self, puzzle):
'''Constructs the soduku puzzle from the file.'''
self.grid = []
with open(puzzle, "r") as f:
for line in f:
# strip CR/LF, replace . by space, make a list of chars
self.grid.append([" " if char in " ." else char for char in line.rstrip("\r\n")])
def __str__(self):
'''Prints the soduku puzzle nicely.'''
lines = []
for i, row in enumerate(self.grid):
if i != 0 and i % 3 == 0:
# add a separator every 3 lines
lines.append("+".join(["-" * 3] * 3))
# add a separator every 3 chars
line = "|".join(map("".join, zip(*([iter(row)] * 3))))
lines.append(line)
lines.append("")
return "\n".join(lines)
请注意,此版本期望文件具有非常严格的格式(没有分隔线或字符,每行确切的字符数)。您可以练习改进它以阅读更多自由格式。
另请注意,我使用的唯一成员变量是
self.grid
。所有其他变量在各自的函数中是局部的。关于python - Python数独难题求解器无法正确显示难题,我们在Stack Overflow上找到一个类似的问题:https://stackoverflow.com/questions/16932831/