我仍在学习Haskell,并编写了以下基数排序函数。它似乎可以正常工作,但是问题在于它的内存效率很低。如果使用ghc进行编译,则使用大小为10000个元素的输入列表时,内存已经超过500MB。
因此,我想问您如何改进以下算法/代码以使其在速度和内存方面更有效。最好的起点是什么?
import System.Random
-- radixsort for positive integers. uses 10 buckets
radixsort :: [Int] -> [Int]
radixsort [] = []
radixsort xs =
-- given the data, get the number of passes that are required for sorting
-- the largest integer
let maxPos = floor ((log (fromIntegral (foldl max 0 xs)) / log 10) + 1)
-- start sorting from digit on position 0 (lowest position) to position 'maxPos'
radixsort' ys pos
| pos < 0 = ys
| otherwise = let sortedYs = radixsort' ys (pos - 1)
newBuckets = radixsort'' sortedYs [[] | i <- [1..10]] pos
in [element | bucket <- newBuckets, element <- bucket]
-- given empty buckets, digit position and list, sort the values into
-- buckets
radixsort'' [] buckets _ = buckets
radixsort'' (y:ys) buckets pos =
let digit = div (mod y (10 ^ (pos + 1))) (10 ^ pos)
(bucketsBegin, bucketsEnd) = splitAt digit buckets
bucket = head bucketsEnd
newBucket = bucket ++ [y]
in radixsort'' ys (bucketsBegin ++ [newBucket] ++ (tail bucketsEnd)) pos
in radixsort' xs maxPos
-- get an random array given an seed
getRandIntArray :: Int -> [Int]
getRandIntArray seed = (randomRs (0, div (maxBound :: Int) 2) (mkStdGen seed))
main = do
value <- (\x -> return x ) (length (radixsort (take 10000 (getRandIntArray 0))))
print value
最佳答案
主要问题是您的函数radixsort''
,因为++
是O(n),并且每次将作为第一个参数给出的列表都复制一次。
pack (-1) r' _ = r'
pack n r' relems =
let getn = (map snd) . (filter ((n==) . fst))
in pack (n - 1) ((getn relems):r') relems
radixsort'' elems pos =
let digit = \y -> div (mod y (10 ^ (pos + 1))) (10 ^ pos)
relems = zip (map digit elems) elems
in pack 9 [] relems