我目前正在实现一个简单的图类,而我想要的方法之一是让它返回一个随机邻居,如下所示。但是,我发现每次运行程序时,return nborList[r]
总是返回nborList中的相同元素。
IDType Graph::random_neighbor(const IDType source) const
{
IDVector nborList = neighbors(source);
IDType r = nrand(nborList.size());
cout << "TEST Neighbors: ";
for (IDVector::const_iterator iter = nborList.begin();
iter != nborList.end(); ++iter)
cout << *iter << " ";
cout << endl;
cout << "TEST Rand: " << r << endl;
return nborList[r];
}
int nrand(int n) // Returns number [0, n), taken from Accelerated C++
{
if (n <= 0 || n > RAND_MAX)
throw domain_error("Argument to nrand is out of range");
const int bucket_size = RAND_MAX / n;
int r;
do r = rand() / bucket_size;
while (r >= n);
return r;
}
我正在使用此Graph类的
test.cpp
文件具有以下代码:#include <ctime>
#include <iostream>
#include "Graph.h"
using std::cout;
using std::endl;
int main()
{
srand(time(NULL));
Graph G(50);
for (int i = 1; i < 25; ++i)
if (i % 2 == 0)
G.add_edge(0, i);
G.add_edge(2, 49);
cout << "Number of nodes: " << G.size() << endl;
cout << "Number of edges: " << G.number_of_edges() << endl;
cout << "Neighbors of node 0: ";
IDVector nborList = G.neighbors(0);
for (IDVector::const_iterator iter = nborList.begin();
iter != nborList.end(); ++iter)
cout << *iter << " ";
cout << endl << endl;
cout << "Random neighbor: " << G.random_neighbor(0) << endl;
cout << "Random number: " << nrand(nborList.size()) << endl;
return 0;
}
输出:
Number of nodes: 50
Number of edges: 13
Neighbors of node 0: 2 4 6 8 10 12 14 16 18 20 22 24
TEST Neighbors: 2 4 6 8 10 12 14 16 18 20 22 24
TEST Rand: 1
Random neighbor: 4
Random number: 9
我得到的输出是每次,除了最后一行说
Random number: 9
会发生变化的输出。但是,TEST Rand: 1
始终为1,有时在我重新编译时,它将更改为不同的数字,但是在多次运行时,它将保持相同的数字。使用nrand(nborList.size())
,这两个地方的电话似乎都一样,nborList = neighbors(source)
..帮助吗?谢谢!
最佳答案
众所周知,rand()
很笨拙。如果您运行一些测试并使用时间上接近的种子,那么它产生的第一个数字将始终是值接近的。如果可以的话,我建议您使用boost::random
之类的东西。