java - 分类功能-如何改善

我有以下代码进行排序。这可以改善吗？

import java.util.*;
class Church {
    private String name;
    private String pastor;
    public Church(String name, String pastor) {
        this.name = name;
        this.pastor = pastor;
    }
    public String getPastor() {
        return pastor;
    }
    public String getName() {
        return name;
    }
    public void setPastor(String pastor) {
        this.pastor = pastor;
    }
    public String toString() {
        return getName() + " is Pastored by "+getPastor();
    }
    public int compareByPastor(Church c) {
        int x = pastor.compareTo(c.getPastor());
        return x;
    }
    public int compareByName(Church c) {
        int x = name.compareTo(c.getName());
        return x;
    }
}

class Churches {
    private final List<Church> churches;

    public Churches() {
        churches = new ArrayList<Church>();
    }
    public void addWithoutSorting(Church c) {
        churches.add(c);
    }

    //You could always add using this method
    public void addWithSorting(Church c) {

    }
    public void display() {
        for(int j = 0; j < churches.size(); j++) {
            System.out.print(churches.get(j).toString());
            System.out.println("");
        }
   }
   public List<Church> getChurches() {
       return churches;
   }
   public void sortBy(String s) {
       for (int i = 1; i < churches.size(); i++) {
           int j;
           Church val = churches.get(i);
           for (j = i-1; j > -1; j--) {
               Church temp = churches.get(j);
               if(s.equals("Pastor")) {
                   if (temp.compareByPastor(val) <= 0) {
                       break;
                   }
               }
               else if(s.equals("Name")) {
                   if (temp.compareByName(val) <= 0) {
                          break;
                   }
               }
               churches.set(j+1, temp);
            }
            churches.set(j+1, val);
       }
     }

    public static void main(String[] args) {
        Churches baptists = new Churches();
        baptists.addWithoutSorting(new Church("Pac", "Pastor G"));
        baptists.addWithoutSorting(new Church("New Life", "Tudor"));
        baptists.addWithoutSorting(new Church("My Church", "r035198x"));
        baptists.addWithoutSorting(new Church("AFM", "Cathy"));
        System.out.println("**********************Before Sorting***********************");
        baptists.display();
        baptists.sortBy("Pastor");
        System.out.println("**********************After sorting by Pastor**************");
        baptists.display();
        baptists.sortBy("Name");
        System.out.println("**********************After sorting by Name****************");
        baptists.display();

    }

  }

最佳答案

看看Collections.sort（列表，比较器）
http://download.oracle.com/javase/6/docs/api/java/util/Collections.html

关于java - 分类功能-如何改善，我们在Stack Overflow上找到一个类似的问题：https://stackoverflow.com/questions/5303171/