我用Java编写了2个类。它们是DeveloperGroupManager。开发人员的字段private GroupManager supervisor(带有getter和setter)描述了谁雇用他。而且,GroupManager具有以下方法:

public class GroupManager {

    //...

    private List<Developer> employees;

    public void hire(Developer e) {
        if(canHire()) {
            if(employees.contains(e)) {
                System.out.println(e.getName() + " is already hired");
            }
            else {
                e.setSupervisor(this);
                employees.add(e);
                System.out.println(getName() + " is now hiring " + e.getName());
            }
        }
        else {
            System.out.println(getName() + "cannot hire more employees.");
        }
    }

}


此类公开方法hire,该方法在给定的开发人员上设置主管。
我想为类Developer编写测试。
我这样做是这样的:

@Test
public void hiringWorksAsItShould() throws Exception {
    GroupManager gm = new GroupManager("John Doe", "manager", 1);
    gm.hire(developer);
    assertThat(developer.getSupervisor()).isInstanceOf(GroupManager.class);
}


我正在使用FEST测试框架,但是由于它非常直观,所以我相信每个人都可以理解它的含义。该测试通过了,但是因为我希望它成为单元测试,所以决定用= new GroupManager替换= mock(GroupManager.class)。问题是现在该测试失败了。我如何更正此Mockito功能以检查开发人员的主管是GroupManager的实例。

编辑
我得到的错误:

java.lang.AssertionError: expecting actual value not to be null
    at org.fest.assertions.Fail.failure(Fail.java:228)
    at org.fest.assertions.Fail.fail(Fail.java:167)
    at org.fest.assertions.Fail.failIfActualIsNull(Fail.java:100)
    at org.fest.assertions.GenericAssert.isNotNull(GenericAssert.java:238)
    at org.fest.assertions.ObjectAssert.isInstanceOf(ObjectAssert.java:52)
    at DeveloperTest.hiringWorksAsItShould(DeveloperTest.java:23)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
    at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:78)
    at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:212)
    at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)


开发人员类:

public class Developer {
    private final String name;
    private String role;
    private Manager supervisor;


    public Manager getSupervisor() {
        return supervisor;
    }

    public void setSupervisor(Manager supervisor) {
        this.supervisor = supervisor;
    }
}


DeveloperTest类:

import org.junit.Test;

import static org.fest.assertions.Assertions.*;
import static org.mockito.Mockito.mock;

public class DeveloperTest {

    static final Developer developer = new Developer("John Doe", "developer");



    @Test
    public void hiringWorksAsItShould() throws Exception {
        GroupManager gm = mock(GroupManager.class);
        gm.hire(developer);
        assertThat(developer.getSupervisor()).isInstanceOf(GroupManager.class);

    }


提前致谢。

最佳答案

您确定要用模拟而不是员工替换GroupManager吗?

如果你有...

@Test
public void hiringWorksAsItShould() throws Exception {
    GroupManager gm = mock(GroupManager.class);

    gm.hire(developer); // YOU ARE CALLING THE MOCK HERE THEN!!
    assertThat(developer.getSupervisor()).isInstanceOf(GroupManager.class);
}


您不是要这样吗?

@Test
public void hiringWorksAsItShould() throws Exception {
    // CLASS UNDER TEST   \/
    GroupManager gm = new GroupManager("John Doe", "manager", 1);

    // Mock "developer"...
    Developer developer = mock(Developer.class);

    gm.hire(developer);

    verify(developer).setSupervisor(gm);
}


因此,当您测试GroupManager时,这应该是一个可靠的实现,并且应该模仿与之交互的事物(即Developer)。

07-26 02:34