我正在尝试遵循ReentrantLock Example in Java, Difference between synchronized vs ReentrantLock类教程。我有一个以-ea开头的演示

public class ReentrantLockZero {
    private static ReentrantLock CountLock = new ReentrantLock();
    private static int count = 0;
    private static final int RESULT_COUNT = 10_000;

    public static void main(String... args) throws Exception {
        ThreadPoolExecutor threadPoolExecutor = getMyCachedThreadPool();
        for (int i = 0; i < RESULT_COUNT; ++i) {
            threadPoolExecutor.submit(ReentrantLockZero::getCount);
            threadPoolExecutor.submit(ReentrantLockZero::getCountUsingLock);
        }
        threadPoolExecutor.shutdown();
        threadPoolExecutor.awaitTermination(10, TimeUnit.SECONDS);
        assert count == RESULT_COUNT * 2;
    }

    private static synchronized int getCount() {
        count++;
        System.out.println(Thread.currentThread().getName() + " counting in synchronized: " + count);
        return count;
    }

    private static int getCountUsingLock() {
        CountLock.lock();
        try {
            count++;
            System.out.println(Thread.currentThread().getName() + " counting in lock: " + count);
            return count;
        } finally {
            CountLock.unlock();
        }
    }
}


当使用ReentrantLock作为第二种方法getCountUsingLock时,我会得到java.lang.AssertionError,但是当我注释掉它们以使用synchronized时,这是可以的。

考虑到它的ReentrantLock,我删除了该类中定义的CountLock并按以下方式使用本地锁,但是它仍然无法正常工作。

private static int getCountUsingLock() {
    ReentrantLock countLock = new ReentrantLock();
    countLock.lock();
    try {
        count++;
        System.out.println(Thread.currentThread().getName() + " counting in lock: " + count);
        return count;
    } finally {
        countLock.unlock();
    }
}


这里错过了什么?

任何帮助将不胜感激 ;)

最佳答案

我有点傻瓜。

之所以这样工作是因为我实际上锁定了不同的对象。

private static synchronized int getCount()


等于

private static synchronized (ReentrantLockZero.class) int getCount()


new ReentrantLock();始终是一个新对象,无法使用不同的锁来消除race condition

真是我的傻瓜,可以通过以下演示轻松修复

public class ReentrantLockZero {
    private static ReentrantLock CountLock = new ReentrantLock();
    private static int synchronisedCount = 0;
    private static int lockedCount = 0;
    private static final int RESULT_COUNT = 10_000;

    public static void main(String... args) throws Exception {
        ThreadPoolExecutor threadPoolExecutor = getMyCachedThreadPool();
        for (int i = 0; i < RESULT_COUNT; ++i) {
            threadPoolExecutor.submit(ReentrantLockZero::getSynchronisedCount);
            threadPoolExecutor.submit(ReentrantLockZero::getCountUsingLock);
        }
        threadPoolExecutor.shutdown();
        threadPoolExecutor.awaitTermination(10, TimeUnit.SECONDS);
        assert synchronisedCount == RESULT_COUNT;
        assert lockedCount == RESULT_COUNT;
    }

    private static synchronized int getSynchronisedCount() {
        synchronisedCount++;
        System.out.println(Thread.currentThread().getName() + " counting in synchronized: " + synchronisedCount);
        return synchronisedCount;
    }

    private static int getCountUsingLock() {
        CountLock.lock();
        try {
            lockedCount++;
            System.out.println(Thread.currentThread().getName() + " counting in lock: " + lockedCount);
            return lockedCount;
        } finally {
            CountLock.unlock();
        }
    }
}




synchronized为什么起作用?因为那时只有一个锁,所以这两种方法都处于锁定状态,因此竞争条件可以直接解决。

有点容易被本教程所愚弄;对我感到羞耻;(

关于java - 为什么在演示中同步工作时ReentrantLock不起作用?,我们在Stack Overflow上找到一个类似的问题:https://stackoverflow.com/questions/55428346/

10-10 09:52