This question already has answers here:
Alternative to a million IF statements
                                
                                    (3个答案)
                                
                        
                                6年前关闭。
            
                    
我刚刚开始学习php,javascript等。。。尝试使用ajax做一个成员系统,今天做完,然后再检查一次,发现我只使用if else语句来完成所有代码。 。有更好的方法吗?

member-update.js

$('#member_update_form').submit(false);

function check_member_update(){
    $.ajax({
        type: "POST",
        url: "../handlers/member_update_validation.php?do=update",
        data: $("#member_update_form").serialize(),
        dataType: "json",
        success: function(msg){
            if(msg.status == 'error'){
                $("#error_dialog_box").html('出錯,請再嘗試');
                update_showWarning();
            }
            if(msg.status == 'cookie_error'){
                $("#error_dialog_box").html('帳號信息出錯,請重新登入');
                update_showWarning();
            }
            if(msg.status == 'captcha_error'){
                $("#error_dialog_box").html('請正確輸入驗證碼');
                update_showWarning();
            }
            if(msg.status == 'username_error'){
                $("#error_dialog_box").html('請別嘗試修改用戶名');
                update_showWarning();
            }
            if(msg.status == 'name_error'){
                $("#error_dialog_box").html('請輸入暱稱,1-10個字符');
                update_showWarning();
            }
            if(msg.status == 'email_empty'){
                $("#error_dialog_box").html('電子郵件地址不能為空');
                update_showWarning();
            }
            if(msg.status == 'email_format_error'){
                $("#error_dialog_box").html('電子郵件地址格式錯誤');
                update_showWarning();
            }
            if(msg.status == 'email_taken'){
                $("#error_dialog_box").html('輸入的電子郵件地址已被使用');
                update_showWarning();
            }
            if(msg.status == 'password_error'){
                $("#error_dialog_box").html('密碼錯誤!不可使用符號或中文!6-40字符');
                update_showWarning();
            }
            if(msg.status == 'update_password_error'){
                $("#error_dialog_box").html('新密碼錯誤!不可使用中文符號或中文!6-40字符');
                update_showWarning();
            }
            if(msg.status == 'update_password_not_match'){
                $("#error_dialog_box").html('新密碼與確認新密碼不一致');
                update_showWarning();
            }
            if(msg.status == 'update_wrong_password'){
                $("#error_dialog_box").html('當前密碼輸入錯誤,請再次確認');
                update_showWarning();
            }
            if(msg.status == 'update_success_all'){
                $("#success_dialog_box").html('已成功更改個人資料,請重新登入');
                update_showSuccessRelog();
            }
            if(msg.status == 'update_success'){
                $("#success_dialog_box").html('已成功更改個人資料');
                update_showSuccess();
            }
        },
        error: function(){
            document.getElementById('update_captcha_img').src = '/securimage/securimage_show.php?' + Math.random();
            alert('未知錯誤,請聯絡管理員');
        }
    });
    //make sure the form doesn't post
    return false;
};


member_update_validation.php

<?php

include_once $_SERVER['DOCUMENT_ROOT'] . '/securimage/securimage.php';
$securimage = new Securimage();
$response_array = array();
require $_SERVER['DOCUMENT_ROOT'] . '/common/db/main.db.php';

if(!empty($_GET['do']) && $_SESSION['loggedIn'] == 1 && isset($_COOKIE['logintoken'])){
    if($_GET['do'] == 'update'){

        if($_SESSION['logintoken'] != $_COOKIE['logintoken']){
            $response_array['status'] = 'cookie_error';
        }else{
            $logintoken = $_COOKIE['logintoken'];

            $database = new Database();
            $database->query('SELECT * FROM member_info WHERE logintoken = :logintoken');
            $database->bind(':logintoken',$logintoken);
            $check_user = $database->single();

            $username = mysql_real_escape_string(strtolower($check_user['username']));
            $name = mysql_real_escape_string($_POST['update_name']);
            $email = mysql_real_escape_string($_POST['update_email']);
            if(!empty($_POST['update_contact'])){
                $contact = mysql_real_escape_string($_POST['update_contact']);
            }else{
                $contact = '';
            }
            if(!empty($_POST['update_bday'])){
                $bdate = mysql_real_escape_string($_POST['update_bday']);
            }else{
                $bdate = '';
            }
            $password = mysql_real_escape_string($_POST['password']);
            if(!empty($_POST['update_password'])){
                $update_password = mysql_real_escape_string($_POST['update_password']);
            }else{
                $update_password = '';
            }
            if(!empty($_POST['update_confirm_password'])){
                $update_confirm_password = mysql_real_escape_string($_POST['update_confirm_password']);
            }else{
                $update_confirm_password = '';
            }
            $captcha = mysql_real_escape_string($_POST['update_captcha']);
            unset($_POST);

            if(empty($captcha) || $securimage->check($captcha) == false){
                $response_array['status'] = 'captcha_error';
            }
            if($username != $check_user['username']){
                $response_array['status'] = 'username_error';
            }
            if(strlen($name) < 1 || strlen($name) > 10){
                $response_array['status'] = 'name_error';
            }
            if(empty($email)){
                $response_array['status'] = 'email_empty';
            }
            if(filter_var($email, FILTER_VALIDATE_EMAIL) === FALSE){
                $response_array['status'] = 'email_format_error';
            }
            if($email != $check_user['email']){

                $database = new Database();
                $database->query('SELECT * FROM member_info WHERE email = :email');
                $database->bind(':email',$email);
                $exmail = $database->single();

                if(!empty($exmail)){
                    $response_array['status'] = 'email_taken';
                    unset($exmail);
                }
            }
            if(strlen($password) < 6 || strlen($password) > 40){
                $response_array['status'] = 'password_error';
            }
            if(!empty($update_password) && !empty($update_confirm_password)){
                if(strlen($update_password) < 6 || strlen($update_password) > 40){
                    $response_array['status'] = 'update_password_error';
                }
                if($update_password != $update_confirm_password){
                    $response_array['status'] = 'update_password_not_match';
                }
            }

            if(empty($response_array['status'])){

                $check_password = hash('sha256', $password . $check_user['salt']);
                for($round = 0; $round < 65536; $round++){
                    $check_password = hash('sha256', $check_password . $check_user['salt']);
                }
                if($check_password === $check_user['password']){
                    $login_ok = true;
                }else{
                    $login_ok = false;
                    $response_array['status'] = 'update_wrong_password';
                }
                if($login_ok == true){
                    if(!empty($update_password)){

                        $salt = dechex(mt_rand(0, 2147483647)) . dechex(mt_rand(0, 2147483647));
                        $update_password = hash('sha256', $update_password . $salt);
                        for($round = 0; $round < 65536; $round++){
                            $update_password = hash('sha256', $update_password . $salt);
                        }

                        $database = new Database();
                        $database->query('UPDATE member_info SET email = :email, name = :name, contact = :contact, birthdate = :bdate, password = :update_password, salt = :salt WHERE username = :username');
                        $database->bind(':username', $check_user['username']);
                        $database->bind(':email', $email);
                        $database->bind(':name', $name);
                        $database->bind(':contact', $contact);
                        $database->bind(':bdate', $bdate);
                        $database->bind(':update_password', $update_password);
                        $database->bind(':salt', $salt);
                        $database->execute();

                        $response_array['status'] = 'update_success_all';
                    }else{
                        $database = new Database();
                        $database->query('UPDATE member_info SET email = :email, name = :name, contact = :contact, birthdate = :bdate WHERE username = :username');
                        $database->bind(':username', $check_user['username']);
                        $database->bind(':email', $email);
                        $database->bind(':name', $name);
                        $database->bind(':contact', $contact);
                        $database->bind(':bdate', $bdate);
                        $database->execute();

                        $response_array['status'] = 'update_success';
                    }
                }
            }

        }

    }else{
        $response_array['status'] = 'error';
    }
    unset($check_user);
    echo json_encode($response_array);
    unset($response_array);
    return false;
}else{
    header('Location: index.php');
}

?>


member-update.js ajax发布到member_update_validation.php并取回$response_array['status']并根据状态运行一些jquery代码...这里只是更新代码,我还有4个文件几乎相同用于登录和注册。 ..除了声明以外,有人能给我指出正确的方法吗?

最佳答案

第一个片段是localization的问题:您通常希望从代码中提取接口消息,以便可以轻松地编辑和翻译它们。然后,您可以使用一个键来引用每个消息,并利用这些键来简化控制流程:

var messages = {
    error: '出錯,請再嘗試',
    cookie_error: '帳號信息出錯,請重新登入',
    ...
};

function onUpdateSuccess(msg) {
    var errorMessage = messages[msg.status];
    $("#success_dialog_box").html(errorMessage);
    update_showSuccessRelog();
}


之后,您可以在服务器端生成messages对象,将其存储在数据库中,使其取决于当前选择的站点语言等。

在服务器端,您可能希望分离验证逻辑并使它可重用:

class Validate {
    public static function length($input, $min, $max) {
        $length = strlen($input);
        return $length >= min && $length <= $max;
    }

    public static function notEmpty($input) {
        return !empty($input);
    }

    public static function email($input) {
        return filter_var($input, FILTER_VALIDATE_EMAIL);
    }
    ...
}


然后,您可以使用验证器组件从控制逻辑中提取验证条件:

$validationRules = array(
    'username' => array(
        array('length', 1, 10, 'name_error'),
    ),
    'email' => array(
        array('notEmpty', 'email_empty'),
        array('email', 'email_format_error'),
    ),
    ...
);

$formData = array();
foreach (array('username', 'email', ...) as $input) {
    $formData[$input] = empty($_POST[$input]) ? '' : $_POST[$input];
    // if Database::bind() is sanely written, mysql_real_escape_string is unnecessary
}

$errors = array();
foreach ($formData as $field => $value) {
    if (isset($validationRules[$field]) {
        foreach ($validationRules[$field] as $rule) {
            $ruleName = $rule[0];
            $error = end($rule);
            $arguments = array_slice($rule, 1, -1);
            array_unshift($arguments, $value);
            $valid = call_user_func_array(array('Validate', $ruleName), $arguments);
            if (!valid) {
                $errors[$field] = $error;
                break;
            }
        }
    }
}

关于php - 更好的方法吗?除了很多其他条件之外,我们在Stack Overflow上找到一个类似的问题:https://stackoverflow.com/questions/16648691/

10-09 08:13
查看更多